review

review.md

1. Goal

Rules for reviewing code and detecting errors or inconsistencies.

---

2. Principles

• Follow architecture.md and the corresponding technical skills
• Review modularity, security, data integrity, and naming consistency
• Do not approve code that violates critical rules

---

3. Required checklist

• Variables y funciones modularizadas
• JS nativo (vanilla) y ES Modules
• JSON used in read-only mode
• Uso correcto de APIs Joomla
• Override seguro
• CSS BEM
• SEO básico aplicado
• ACL respetado
• Sin librerías externas no permitidas

---

4. Review closure

• Confirm definition-of-done.md before approval

---

5. Anti-patterns

• Mixing responsibilities in one module
• Global variables
• Unnecessary inline data
• Unnecessary direct SQL

---

6. Review example

JS file mixing UI and map logic in one place → fail Modular JS file with import/export and proper fetch flow → pass